BUG: Logbook
-
So I started a first “Tiger spirit” campaign in 4.33,
and flew a SWEEP out of kangung as lead (+3 AI).We couldn’t get to the target area because we have been
intercepted long before.While #2 and #3 called winchester, I decided to save my flight and
turned to the tanker area for a refuell training.After we got all gas we RTB.
Sadly #3 and #4 crashed at kangung approach (known bug)In the debriefing I was promoted as a 2nd Lieutenant, YEAH !
Hold on, I’m already a Colonel in 4.32, … so HUH?
If I load my logbook into editor, my Rank is promoted to Brigardier general.
So anything wrong with the promotion from Colonel to Brigardier general?
Cheers,
LS -
Obviously this kind of performance demanded a rank deduction. Just falcon tried to trick you. It’s alive…
//Arty runs and hides. :rofl: -
OK, while I’m still not a coder, … I took a look into old code at github.
/src/ui/include/logbook.h ( line #20 - #31 )
//Ranks typedef enum { SEC_LT, LEIUTENANT, CAPTAIN, MAJOR, LT_COL, COLONEL, BRIG_GEN, NUM_RANKS, } LB_RANK;
/src/ui/src/logbook/logbook.cpp ( line #622 - #658 )
void LogBookData::CalcRank(void) { LB_RANK NewRank = SEC_LT; if ((Pilot.Campaign.TotalScore > 3200) and Pilot.Campaign.GamesWon) { NewRank = COLONEL; } else if ((Pilot.Campaign.TotalScore > 1600) and \ (Pilot.Campaign.GamesWon or Pilot.Campaign.GamesTied)) { NewRank = LT_COL; } else if ((Pilot.Campaign.TotalScore > 800) and \ (Pilot.Campaign.GamesWon or Pilot.Campaign.GamesTied or Pilot.Campaign.GamesLost)) { NewRank = MAJOR; } else if (Pilot.Campaign.TotalScore > 300) { NewRank = CAPTAIN; } else if (Pilot.Campaign.TotalScore > 150) { NewRank = LEIUTENANT; } else { NewRank = SEC_LT; } if (NewRank > Pilot.Rank) { MissionResult or_eq PROMOTION; Pilot.Rank = NewRank; } }
As you can see there is no BRIG_GEN Rank calculated at all, so …
else
{
NewRank = SEC_LT;
}On the other hand, … the code says Colonel is the highest Rank calculated,
if ((Pilot.Campaign.TotalScore > 3200) and Pilot.Campaign.GamesWon)
{
NewRank = COLONEL;
}… so according to TotalScore I shoud have never been promoted, but still being Colonel.
(Pilot.Campaign.GamesWon is true for LS anyway)So maybe anything wrong with the TotalScore calculation?
(is there a max. limit after the calculation will fail?)
BTW. in my LBK “Total Score 26153” atm.Cheers,
LS -
Log Book editor will mess up your log book,
Any one who uses log book editor is suspect and should be placed under house arrest until their name is cleared of all infered and related fraud.
Sir you may need legal counsel. :?
-
@Arty and Shadow
The laugh is always on the loser.
So Thank’s a lot to you both.And yes, I’ve edited my logbook around 2006 for a similar reason,
after I was told to do so on Frugals.
(so this bug seems to be an really old one)I remember I was told to decrease a value to get my rank back,
but I can’t remember what value it was.Looking at the old screenshot’s it seems it wasn’t the Total Score value.
The only thing what is really wrong in my actually LB (beside rank now) are those 40 won campaigns,
whereat ~ 12 of them are result of testing, so they should be reduced by 12 someday.I hope a dev can fix this serious showstopper bug ASAP, LOL.
… or can at least confirm or deny a bug.Cheers,
LS -